[InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` #65852

dtcxzyw · 2023-09-09T16:03:16Z

This patch folds the pattern a ne/eq (zext/sext (a ne/eq c)) into a boolean constant or a compare.
Clang vs GCC: https://godbolt.org/z/4ro817WE8
Proof for zext: https://alive2.llvm.org/ce/z/6z9NRF
Proof for sext: https://alive2.llvm.org/ce/z/tv5wuE
Fixes #65073.

llvm/test/Transforms/InstCombine/icmp-range.ll

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

llvmbot · 2023-09-18T14:34:06Z

@llvm/pr-subscribers-llvm-transforms

Changes

This patch folds the pattern a ne/eq (zext (a ne/eq c)) into a boolean constant or a compare.
Clang vs GCC: https://godbolt.org/z/4ro817WE8
Alive2: https://alive2.llvm.org/ce/z/6z9NRF
Fixes #65073.

Full diff: https://github.com/llvm/llvm-project/pull/65852.diff

2 Files Affected:

(modified) llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp (+62)
(modified) llvm/test/Transforms/InstCombine/icmp-range.ll (+18-58)

diff --git a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
index a219dac7acfbe16..d0b62c17ec94358 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
@@ -6380,7 +6380,69 @@ Instruction *InstCombinerImpl::foldICmpUsingBoolRange(ICmpInst &I) {
       Y->getType()->isIntOrIntVectorTy(1) && Pred == ICmpInst::ICMP_ULE)
     return BinaryOperator::CreateOr(Builder.CreateIsNull(X), Y);
 
+  ICmpInst::Predicate Pred1, Pred2;
   const APInt *C;
+  // icmp eq/ne X, (zext (icmp eq/ne X, C))
+  if (match(&I, m_c_ICmp(Pred1, m_Value(X),
+                         m_ZExt(m_ICmp(Pred2, m_Deferred(X), m_APInt(C))))) &&
+      ICmpInst::isEquality(Pred1) && ICmpInst::isEquality(Pred2)) {
+    if (C->isZero()) {
+      if (Pred2 == ICmpInst::ICMP_EQ) {
+        // icmp eq X, (zext (icmp eq X, 0)) --> false
+        // icmp ne X, (zext (icmp eq X, 0)) --> true
+        return replaceInstUsesWith(
+            I,
+            Constant::getIntegerValue(
+                I.getType(),
+                APInt(1U, static_cast<uint64_t>(Pred1 == ICmpInst::ICMP_NE))));
+      } else {
+        // icmp eq X, (zext (icmp ne X, 0)) --> icmp ult X, 2
+        // icmp ne X, (zext (icmp ne X, 0)) --> icmp ugt X, 1
+        return ICmpInst::Create(
+            Instruction::ICmp,
+            Pred1 == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGT
+                                       : ICmpInst::ICMP_ULT,
+            X,
+            Constant::getIntegerValue(
+                X->getType(), APInt(X->getType()->getScalarSizeInBits(),
+                                    Pred1 == ICmpInst::ICMP_NE ? 1 : 2)));
+      }
+    } else if (C->isOne()) {
+      if (Pred2 == ICmpInst::ICMP_NE) {
+        // icmp eq X, (zext (icmp ne X, 1)) --> false
+        // icmp ne X, (zext (icmp ne X, 1)) --> true
+        return replaceInstUsesWith(
+            I,
+            Constant::getIntegerValue(
+                I.getType(),
+                APInt(1U, static_cast<uint64_t>(Pred1 == ICmpInst::ICMP_NE))));
+      } else {
+        // icmp eq X, (zext (icmp eq X, 1)) --> icmp ult X, 2
+        // icmp ne X, (zext (icmp eq X, 1)) --> icmp ugt X, 1
+        return ICmpInst::Create(
+            Instruction::ICmp,
+            Pred1 == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGT
+                                       : ICmpInst::ICMP_ULT,
+            X,
+            Constant::getIntegerValue(
+                X->getType(), APInt(X->getType()->getScalarSizeInBits(),
+                                    Pred1 == ICmpInst::ICMP_NE ? 1 : 2)));
+      }
+    } else {
+      // C != 0 && C != 1
+      // icmp eq X, (zext (icmp eq X, C)) --> icmp eq X, 0
+      // icmp eq X, (zext (icmp ne X, C)) --> icmp eq X, 1
+      // icmp ne X, (zext (icmp eq X, C)) --> icmp ne X, 0
+      // icmp ne X, (zext (icmp ne X, C)) --> icmp ne X, 1
+      return ICmpInst::Create(
+          Instruction::ICmp, Pred1, X,
+          Constant::getIntegerValue(
+              X->getType(),
+              APInt(X->getType()->getScalarSizeInBits(),
+                    static_cast<uint64_t>(Pred2 == ICmpInst::ICMP_NE))));
+    }
+  }
+
   if (match(I.getOperand(0), m_c_Add(m_ZExt(m_Value(X)), m_SExt(m_Value(Y)))) &&
       match(I.getOperand(1), m_APInt(C)) &&
       X->getType()->isIntOrIntVectorTy(1) &&
diff --git a/llvm/test/Transforms/InstCombine/icmp-range.ll b/llvm/test/Transforms/InstCombine/icmp-range.ll
index a26e760059b43fe..88d5a723747ad5f 100644
--- a/llvm/test/Transforms/InstCombine/icmp-range.ll
+++ b/llvm/test/Transforms/InstCombine/icmp-range.ll
@@ -1037,10 +1037,7 @@ define i1 @icmp_ne_bool_1(ptr %ptr) {
 ; Tests from PR65073
 define i1 @icmp_ne_zext_eq_zero(i32 %a) {
 ; CHECK-LABEL: @icmp_ne_zext_eq_zero(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 0
-; CHECK-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]]
-; CHECK-NEXT:    ret i1 [[CMP1]]
+; CHECK-NEXT:    ret i1 true
 ;
   %cmp = icmp eq i32 %a, 0
   %conv = zext i1 %cmp to i32
@@ -1050,9 +1047,7 @@ define i1 @icmp_ne_zext_eq_zero(i32 %a) {
 
 define i1 @icmp_ne_zext_ne_zero(i32 %a) {
 ; CHECK-LABEL: @icmp_ne_zext_ne_zero(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 0
-; CHECK-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]]
+; CHECK-NEXT:    [[CMP1:%.*]] = icmp ugt i32 [[A:%.*]], 1
 ; CHECK-NEXT:    ret i1 [[CMP1]]
 ;
   %cmp = icmp ne i32 %a, 0
@@ -1063,10 +1058,7 @@ define i1 @icmp_ne_zext_ne_zero(i32 %a) {
 
 define i1 @icmp_eq_zext_eq_zero(i32 %a) {
 ; CHECK-LABEL: @icmp_eq_zext_eq_zero(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 0
-; CHECK-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]]
-; CHECK-NEXT:    ret i1 [[CMP1]]
+; CHECK-NEXT:    ret i1 false
 ;
   %cmp = icmp eq i32 %a, 0
   %conv = zext i1 %cmp to i32
@@ -1076,9 +1068,7 @@ define i1 @icmp_eq_zext_eq_zero(i32 %a) {
 
 define i1 @icmp_eq_zext_ne_zero(i32 %a) {
 ; CHECK-LABEL: @icmp_eq_zext_ne_zero(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 0
-; CHECK-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]]
+; CHECK-NEXT:    [[CMP1:%.*]] = icmp ult i32 [[A:%.*]], 2
 ; CHECK-NEXT:    ret i1 [[CMP1]]
 ;
   %cmp = icmp ne i32 %a, 0
@@ -1089,9 +1079,7 @@ define i1 @icmp_eq_zext_ne_zero(i32 %a) {
 
 define i1 @icmp_ne_zext_eq_one(i32 %a) {
 ; CHECK-LABEL: @icmp_ne_zext_eq_one(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 1
-; CHECK-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]]
+; CHECK-NEXT:    [[CMP1:%.*]] = icmp ugt i32 [[A:%.*]], 1
 ; CHECK-NEXT:    ret i1 [[CMP1]]
 ;
   %cmp = icmp eq i32 %a, 1
@@ -1102,10 +1090,7 @@ define i1 @icmp_ne_zext_eq_one(i32 %a) {
 
 define i1 @icmp_ne_zext_ne_one(i32 %a) {
 ; CHECK-LABEL: @icmp_ne_zext_ne_one(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 1
-; CHECK-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]]
-; CHECK-NEXT:    ret i1 [[CMP1]]
+; CHECK-NEXT:    ret i1 true
 ;
   %cmp = icmp ne i32 %a, 1
   %conv = zext i1 %cmp to i32
@@ -1115,9 +1100,7 @@ define i1 @icmp_ne_zext_ne_one(i32 %a) {
 
 define i1 @icmp_eq_zext_eq_one(i32 %a) {
 ; CHECK-LABEL: @icmp_eq_zext_eq_one(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 1
-; CHECK-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]]
+; CHECK-NEXT:    [[CMP1:%.*]] = icmp ult i32 [[A:%.*]], 2
 ; CHECK-NEXT:    ret i1 [[CMP1]]
 ;
   %cmp = icmp eq i32 %a, 1
@@ -1128,10 +1111,7 @@ define i1 @icmp_eq_zext_eq_one(i32 %a) {
 
 define i1 @icmp_eq_zext_ne_one(i32 %a) {
 ; CHECK-LABEL: @icmp_eq_zext_ne_one(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 1
-; CHECK-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]]
-; CHECK-NEXT:    ret i1 [[CMP1]]
+; CHECK-NEXT:    ret i1 false
 ;
   %cmp = icmp ne i32 %a, 1
   %conv = zext i1 %cmp to i32
@@ -1141,9 +1121,7 @@ define i1 @icmp_eq_zext_ne_one(i32 %a) {
 
 define i1 @icmp_ne_zext_eq_non_boolean(i32 %a) {
 ; CHECK-LABEL: @icmp_ne_zext_eq_non_boolean(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 2
-; CHECK-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]]
+; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne i32 [[A:%.*]], 0
 ; CHECK-NEXT:    ret i1 [[CMP1]]
 ;
   %cmp = icmp eq i32 %a, 2
@@ -1154,9 +1132,7 @@ define i1 @icmp_ne_zext_eq_non_boolean(i32 %a) {
 
 define i1 @icmp_ne_zext_ne_non_boolean(i32 %a) {
 ; CHECK-LABEL: @icmp_ne_zext_ne_non_boolean(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 2
-; CHECK-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne i32 [[CONV]], [[A]]
+; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne i32 [[A:%.*]], 1
 ; CHECK-NEXT:    ret i1 [[CMP1]]
 ;
   %cmp = icmp ne i32 %a, 2
@@ -1167,9 +1143,7 @@ define i1 @icmp_ne_zext_ne_non_boolean(i32 %a) {
 
 define i1 @icmp_eq_zext_eq_non_boolean(i32 %a) {
 ; CHECK-LABEL: @icmp_eq_zext_eq_non_boolean(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq i32 [[A:%.*]], 2
-; CHECK-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]]
+; CHECK-NEXT:    [[CMP1:%.*]] = icmp eq i32 [[A:%.*]], 0
 ; CHECK-NEXT:    ret i1 [[CMP1]]
 ;
   %cmp = icmp eq i32 %a, 2
@@ -1180,9 +1154,7 @@ define i1 @icmp_eq_zext_eq_non_boolean(i32 %a) {
 
 define i1 @icmp_eq_zext_ne_non_boolean(i32 %a) {
 ; CHECK-LABEL: @icmp_eq_zext_ne_non_boolean(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp ne i32 [[A:%.*]], 2
-; CHECK-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp eq i32 [[CONV]], [[A]]
+; CHECK-NEXT:    [[CMP1:%.*]] = icmp eq i32 [[A:%.*]], 1
 ; CHECK-NEXT:    ret i1 [[CMP1]]
 ;
   %cmp = icmp ne i32 %a, 2
@@ -1192,11 +1164,8 @@ define i1 @icmp_eq_zext_ne_non_boolean(i32 %a) {
 }
 
 define <2 x i1> @icmp_ne_zext_eq_zero_vec(<2 x i32> %a) {
-; CHECK-LABEL: @icmp_ne_zext_eq_zero_vec(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq <2 x i32> [[A:%.*]], zeroinitializer
-; CHECK-NEXT:    [[CONV:%.*]] = zext <2 x i1> [[CMP]] to <2 x i32>
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]]
-; CHECK-NEXT:    ret <2 x i1> [[CMP1]]
+; CHECK-LABEL: @icmp_ne_zext_eq_zero_vec
+; CHECK-NEXT:    ret <2 x i1> <i1 true, i1 true>
 ;
   %cmp = icmp eq <2 x i32> %a, <i32 0, i32 0>
   %conv = zext <2 x i1> %cmp to <2 x i32>
@@ -1206,9 +1175,7 @@ define <2 x i1> @icmp_ne_zext_eq_zero_vec(<2 x i32> %a) {
 
 define <2 x i1> @icmp_ne_zext_ne_zero_vec(<2 x i32> %a) {
 ; CHECK-LABEL: @icmp_ne_zext_ne_zero_vec(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp ne <2 x i32> [[A:%.*]], zeroinitializer
-; CHECK-NEXT:    [[CONV:%.*]] = zext <2 x i1> [[CMP]] to <2 x i32>
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]]
+; CHECK-NEXT:    [[CMP1:%.*]] = icmp ugt <2 x i32> [[A:%.*]], <i32 1, i32 1>
 ; CHECK-NEXT:    ret <2 x i1> [[CMP1]]
 ;
   %cmp = icmp ne <2 x i32> %a, <i32 0, i32 0>
@@ -1219,9 +1186,7 @@ define <2 x i1> @icmp_ne_zext_ne_zero_vec(<2 x i32> %a) {
 
 define <2 x i1> @icmp_ne_zext_eq_one_vec(<2 x i32> %a) {
 ; CHECK-LABEL: @icmp_ne_zext_eq_one_vec(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq <2 x i32> [[A:%.*]], <i32 1, i32 1>
-; CHECK-NEXT:    [[CONV:%.*]] = zext <2 x i1> [[CMP]] to <2 x i32>
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]]
+; CHECK-NEXT:    [[CMP1:%.*]] = icmp ugt <2 x i32> [[A:%.*]], <i32 1, i32 1>
 ; CHECK-NEXT:    ret <2 x i1> [[CMP1]]
 ;
   %cmp = icmp eq <2 x i32> %a, <i32 1, i32 1>
@@ -1232,10 +1197,7 @@ define <2 x i1> @icmp_ne_zext_eq_one_vec(<2 x i32> %a) {
 
 define <2 x i1> @icmp_ne_zext_ne_one_vec(<2 x i32> %a) {
 ; CHECK-LABEL: @icmp_ne_zext_ne_one_vec(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp ne <2 x i32> [[A:%.*]], <i32 1, i32 1>
-; CHECK-NEXT:    [[CONV:%.*]] = zext <2 x i1> [[CMP]] to <2 x i32>
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]]
-; CHECK-NEXT:    ret <2 x i1> [[CMP1]]
+; CHECK-NEXT:    ret <2 x i1> <i1 true, i1 true>
 ;
   %cmp = icmp ne <2 x i32> %a, <i32 1, i32 1>
   %conv = zext <2 x i1> %cmp to <2 x i32>
@@ -1245,9 +1207,7 @@ define <2 x i1> @icmp_ne_zext_ne_one_vec(<2 x i32> %a) {
 
 define <2 x i1> @icmp_ne_zext_eq_non_boolean_vec(<2 x i32> %a) {
 ; CHECK-LABEL: @icmp_ne_zext_eq_non_boolean_vec(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq <2 x i32> [[A:%.*]], <i32 2, i32 2>
-; CHECK-NEXT:    [[CONV:%.*]] = zext <2 x i1> [[CMP]] to <2 x i32>
-; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne <2 x i32> [[CONV]], [[A]]
+; CHECK-NEXT:    [[CMP1:%.*]] = icmp ne <2 x i32> [[A:%.*]], zeroinitializer
 ; CHECK-NEXT:    ret <2 x i1> [[CMP1]]
 ;
   %cmp = icmp eq <2 x i32> %a, <i32 2, i32 2>

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

llvm/test/Transforms/InstCombine/and-or-icmps.ll

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

goldsteinn · 2023-09-24T13:28:42Z

LGTM.

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

dtcxzyw · 2023-09-30T18:31:05Z

Ping.

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

dtcxzyw · 2023-10-05T11:28:32Z

Ping.

goldsteinn · 2023-10-05T16:50:08Z

Continue to LGTM...

nikic

Basically LGTM, but I think this is still missing negative tests for non-equality pred1/pred2?

Add negative tests

nikic · 2023-10-06T10:00:06Z

Looks like incorrect conflict resolution in the last merge.

dtcxzyw · 2023-10-06T11:30:32Z

The conflict resolution should be correct now.

nikic

Yeah, it looks correct now.

[InstCombine] Simplify the pattern a ne/eq (zext (a ne/eq c))

d9d8bcb

dtcxzyw requested review from nikic, goldsteinn and spatel-gh September 9, 2023 16:03

dtcxzyw requested a review from a team as a code owner September 9, 2023 16:03

llvmbot added the llvm:transforms label Sep 9, 2023

Endilll added llvm:instcombine Covers the InstCombine, InstSimplify and AggressiveInstCombine passes and removed llvm:transforms labels Sep 9, 2023

goldsteinn reviewed Sep 11, 2023

View reviewed changes

llvm/test/Transforms/InstCombine/icmp-range.ll Show resolved Hide resolved

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp Outdated Show resolved Hide resolved

nikic reviewed Sep 15, 2023

View reviewed changes

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp Outdated Show resolved Hide resolved

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp Outdated Show resolved Hide resolved

Merge branch 'main' into fold-icmp-eq-zext-eq-self

0c0166c

llvmbot added the llvm:transforms label Sep 18, 2023

dtcxzyw added 2 commits September 18, 2023 22:37

fixup! [InstCombine] Simplify the pattern a ne/eq (zext (a ne/eq c))

bf79e86

fixup! [InstCombine] Simplify the pattern a ne/eq (zext (a ne/eq c))

ba475e3

goldsteinn reviewed Sep 18, 2023

View reviewed changes

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp Outdated Show resolved Hide resolved

Merge branch 'main' into fold-icmp-eq-zext-eq-self

9c9ad18

dtcxzyw removed the request for review from spatel-gh September 18, 2023 17:57

dtcxzyw added 3 commits September 19, 2023 03:30

fixup! [InstCombine] Simplify the pattern a ne/eq (zext (a ne/eq c))

70a70fb

Merge branch 'main' into fold-icmp-eq-zext-eq-self

17b18e0

fixup! [InstCombine] Simplify the pattern a ne/eq (zext (a ne/eq c))

418562d

dtcxzyw changed the title ~~[InstCombine] Simplify the pattern a ne/eq (zext (a ne/eq c))~~ [InstCombine] Simplify the pattern a ne/eq (zext/sext (a ne/eq c)) Sep 18, 2023

dtcxzyw commented Sep 18, 2023

View reviewed changes

llvm/test/Transforms/InstCombine/and-or-icmps.ll Outdated Show resolved Hide resolved

dtcxzyw requested review from goldsteinn and nikic September 18, 2023 20:18

goldsteinn reviewed Sep 18, 2023

View reviewed changes

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp Outdated Show resolved Hide resolved

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp Outdated Show resolved Hide resolved

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp Outdated Show resolved Hide resolved

dtcxzyw added 2 commits September 19, 2023 10:24

[InstCombine] Fix comments zext -> sext. NFC.

b7565cc

fixup! [InstCombine] Simplify the pattern a ne/eq (zext (a ne/eq c))

5b50524

nikic reviewed Sep 24, 2023

View reviewed changes

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp Outdated Show resolved Hide resolved

fixup! [InstCombine] Simplify the pattern a ne/eq (zext (a ne/eq c))

55d52b1

nikic reviewed Sep 30, 2023

View reviewed changes

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp Outdated Show resolved Hide resolved

nikic reviewed Sep 30, 2023

View reviewed changes

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp Outdated Show resolved Hide resolved

dtcxzyw added 2 commits October 1, 2023 20:11

fixup! [InstCombine] Simplify the pattern a ne/eq (zext (a ne/eq c))

c0d8f81

Merge branch 'main' into fold-icmp-eq-zext-eq-self

2e5fe7b

nikic approved these changes Oct 5, 2023

View reviewed changes

fixup! [InstCombine] Simplify the pattern a ne/eq (zext (a ne/eq c))

2285a2c

Add negative tests

Merge branch 'main' into fold-icmp-eq-zext-eq-self

7e81e63

dtcxzyw force-pushed the fold-icmp-eq-zext-eq-self branch from c9ce7de to 7e81e63 Compare October 6, 2023 11:28

nikic approved these changes Oct 6, 2023

View reviewed changes

dtcxzyw merged commit b3b3336 into llvm:main Oct 6, 2023

dtcxzyw deleted the fold-icmp-eq-zext-eq-self branch October 6, 2023 12:57

stepthomas mentioned this pull request Oct 10, 2023

AMDGPU stepthomas atomic csub no rtn forms ver2 stepthomas/llvm-project#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` #65852

[InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` #65852

Uh oh!

dtcxzyw commented Sep 9, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

llvmbot commented Sep 18, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

goldsteinn commented Sep 24, 2023

Uh oh!

Uh oh!

dtcxzyw commented Sep 30, 2023

Uh oh!

Uh oh!

Uh oh!

dtcxzyw commented Oct 5, 2023

Uh oh!

goldsteinn commented Oct 5, 2023

Uh oh!

nikic left a comment

Uh oh!

nikic commented Oct 6, 2023

Uh oh!

dtcxzyw commented Oct 6, 2023

Uh oh!

nikic left a comment

Uh oh!

Uh oh!

[InstCombine] Simplify the pattern a ne/eq (zext/sext (a ne/eq c)) #65852

[InstCombine] Simplify the pattern a ne/eq (zext/sext (a ne/eq c)) #65852

Uh oh!

Conversation

dtcxzyw commented Sep 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

llvmbot commented Sep 18, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

goldsteinn commented Sep 24, 2023

Uh oh!

Uh oh!

dtcxzyw commented Sep 30, 2023

Uh oh!

Uh oh!

Uh oh!

dtcxzyw commented Oct 5, 2023

Uh oh!

goldsteinn commented Oct 5, 2023

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

nikic commented Oct 6, 2023

Uh oh!

dtcxzyw commented Oct 6, 2023

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

[InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` #65852

[InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` #65852

dtcxzyw commented Sep 9, 2023 •

edited

Loading